Make Pods targets inherit deployment target from the app when higher #23679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a few warnings like: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 11.0, but the range of supported deployment target versions is 12.0 to 18.0.99. This post install hook makes pods targets that have a deployment target lower than the app target adopt the app deployment target.
mokagio
commented
Oct 18, 2024
Comment on lines
+115
to
+118
| # Let Pods targets inherit deployment target from the app | ||
| # This solution is suggested here: https://github.com/CocoaPods/CocoaPods/issues/4859 | ||
| pod_ios_deployment_target = Gem::Version.new(config.build_settings['IPHONEOS_DEPLOYMENT_TARGET']) | ||
| config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET' if pod_ios_deployment_target <= APP_IOS_DEPLOYMENT_TARGET |
There was a problem hiding this comment.
Worth noting that the warning Xcode gives is that the deployment target is set to a version lower than the minimum supported one. An alternative fix would have been to set the target to the minimum supported version. The solution here is more portable, though, because it doesn't require updating the override every time the minimum supported target changes.
|
Reverted to draft because of the CI failures... |
Generated by 🚫 Danger |
|
I did a worse version of this in #23736 that should carry us through until we're ready to drop CocoaPods entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I while working on #23678, noticed a few warnings like:
This post install hook makes pods targets that have a deployment target lower than the app target adopt the app deployment target.
Before
After
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary. N.A.UI changes testing checklist: Not a UI PR.